fix(api): best-effort call logging + non-JSON 200 → ModelError (final-review)
- call_log._default_write: swallow any exception from the default file/ stdout sink and report to stderr, so a log-write failure (disk full, bad permissions, misconfigured CALL_LOG_PATH) never turns a successful narration into a 500 (charter §13). Injected write= sinks (used by tests) are left to surface their own errors. - ollama_client.chat: catch ValueError alongside httpx.HTTPError in the retry loop so a 200 response with a non-JSON body (JSONDecodeError is a ValueError subclass) counts as a failed attempt and falls through to ModelError after the one retry, instead of escaping chat() uncaught (charter §12 — one retry, then ModelError, nothing else escapes). - main.py: update stale docstrings — /dm/narrate is now fully wired (routing + model call + logging); the other four roles remain stubs. Regression tests added for both fixes (TDD: watched RED, then GREEN). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -38,7 +38,11 @@ def chat(
|
||||
if content.strip():
|
||||
return content
|
||||
last = "empty response from model"
|
||||
except httpx.HTTPError as exc: # TimeoutException, TransportError, HTTPStatusError
|
||||
except (httpx.HTTPError, ValueError) as exc:
|
||||
# httpx.HTTPError: TimeoutException, TransportError, HTTPStatusError.
|
||||
# ValueError: resp.json() raises json.JSONDecodeError (a ValueError
|
||||
# subclass) on a 200 with a non-JSON body (e.g. a proxy error page) —
|
||||
# treat that as a failed attempt too, not an uncaught escape (§12/§13).
|
||||
last = f"{type(exc).__name__}: {exc}"
|
||||
raise ModelError(last)
|
||||
finally:
|
||||
|
||||
Reference in New Issue
Block a user