Phillip Tarrant
7f1d9fa39a
- canon_log.py: stringify jsonschema error-path segments before sorting so a future schema mixing array indices and object keys can't TypeError (#1) - main.py: RequestValidationError handler reshapes pydantic body failures into the same {"detail": {"canon_log_errors": [...]}} envelope as schema failures, so the client parses ONE 422 shape (#2a) + tests - pytest.ini: filter the starlette/httpx TestClient deprecation → pristine output (#4) - docs/canon-log.md: living contract for the client (Plan B) — schemas, the §7 boundary, the unified error envelope, per-role injection (#3) Full suite 26 passing, 0 warnings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
48 lines
1.5 KiB
Python
48 lines
1.5 KiB
Python
import json
|
|
from pathlib import Path
|
|
|
|
from fastapi.testclient import TestClient
|
|
|
|
from app.main import app
|
|
|
|
client = TestClient(app)
|
|
VALID_LOG = json.load(open(Path(__file__).parent / "fixtures" / "canon_log_valid.json"))
|
|
|
|
ROLE_ENDPOINTS = [
|
|
"/dm/narrate", "/dm/adjudicate", "/dm/improvise",
|
|
"/npc/speak", "/party/banter",
|
|
]
|
|
|
|
|
|
def test_health_ok():
|
|
assert client.get("/health").json() == {"status": "ok"}
|
|
|
|
|
|
def test_every_role_endpoint_accepts_a_valid_canon_log():
|
|
for path in ROLE_ENDPOINTS:
|
|
r = client.post(path, json={"canon_log": VALID_LOG})
|
|
assert r.status_code == 200, f"{path} rejected a valid log: {r.text}"
|
|
|
|
|
|
def test_every_role_endpoint_rejects_an_invalid_canon_log():
|
|
bad = json.loads(json.dumps(VALID_LOG))
|
|
bad["player"]["luck"] = 5 # §7 leak
|
|
for path in ROLE_ENDPOINTS:
|
|
r = client.post(path, json={"canon_log": bad})
|
|
assert r.status_code == 422, f"{path} accepted an invalid log"
|
|
assert "canon_log_errors" in r.json()["detail"]
|
|
|
|
|
|
def test_missing_canon_log_is_a_422():
|
|
r = client.post("/dm/narrate", json={})
|
|
assert r.status_code == 422
|
|
assert "canon_log_errors" in r.json()["detail"]
|
|
|
|
|
|
def test_malformed_body_uses_the_unified_error_shape():
|
|
# A pydantic body failure returns the SAME envelope as a schema failure,
|
|
# so the client only ever parses one 422 shape.
|
|
r = client.post("/dm/narrate", json={"canon_log": "not-a-dict"})
|
|
assert r.status_code == 422
|
|
assert "canon_log_errors" in r.json()["detail"]
|