ptarrant/code_of_conquest_dnd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(client): reject empty player name in NewGame.construct (contract minLength:1)

Browse Source 
Whole-branch review flagged that NewGame.construct validated class and
origin refs but not player.name. The canon-log schema requires
player.name with minLength:1, so a missing/blank name previously
returned ok:true and produced a log the API would reject with 422.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Phillip Tarrant
2026-07-09 15:03:18 -05:00
parent 2d52d74963
commit 63ce3efb74
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
client/scripts/newgame/new_game.gd
View File

@@ -19,6 +19,9 @@ static func construct(origin: Dictionary, world: ContentDB, creation: Dictionary
if class_id not in allowed: if class_id not in allowed:
errors.append("class not allowed by origin: %s" % class_id) errors.append("class not allowed by origin: %s" % class_id)
if creation.get("name", "").strip_edges() == "":
errors.append("player name is required")
if not errors.is_empty(): if not errors.is_empty():
return {"ok": false, "errors": errors, "log": null, "state": null} return {"ok": false, "errors": errors, "log": null, "state": null}

12
client/tests/unit/test_new_game.gd
View File

@@ -87,6 +87,18 @@ func test_unresolved_origin_is_rejected():
assert_true("unresolved ref: location:nowhere" in res["errors"]) assert_true("unresolved ref: location:nowhere" in res["errors"])
func test_empty_name_is_rejected():
var missing_name := _build({"class_id": "sellsword"})
assert_false(missing_name["ok"])
assert_true(missing_name["errors"].size() > 0)
assert_null(missing_name["log"])
var whitespace_name := _build({"name": " ", "class_id": "sellsword"})
assert_false(whitespace_name["ok"])
assert_true(whitespace_name["errors"].size() > 0)
assert_null(whitespace_name["log"])
func test_non_companion_override_goes_to_state_not_log(): func test_non_companion_override_goes_to_state_not_log():
world.npcs["oda_fenn"] = {"id": "oda_fenn", "name": "Oda Fenn", "role": "npc"} world.npcs["oda_fenn"] = {"id": "oda_fenn", "name": "Oda Fenn", "role": "npc"}
var o := _deserter() var o := _deserter()