ptarrant/code_of_conquest_dnd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(creation): distinguish granted skills as owned, and enlarge the small text

Browse Source 
Two F6-review follow-ups from the human's read of the running screen.

1. GRANTED skill chips now read as 'you already have this', not 'unavailable'.
   The elf's granted `perception` shared SkillChip's dim `disabled` look with the
   'picks are spent' chips, so it read as blocked. Split out a fourth state,
   SkillChipGranted — a solid gold fill, cream text, and a ✓ prefix (owned) — while
   the pool-is-spent chips keep the plain dim disabled. Applied per-chip in _bind_skills.

2. Enlarged the small mono/body/prose roles for readability on sub-1920 laptops
   (the 1920 design canvas scales DOWN on a smaller screen, so 11-13px text got
   tiny): DM prose 20->22, MONO 13->14, section labels 13->14, card title 19->20,
   card body 13->14, chips 11->12, skill chips 12->14, the two flag pills +1. Big
   serif headings unchanged.

   Two layout consequences the guards caught and I fixed, not silenced:
   - Race cards overflowed the taller blurb -> card min-height 140->180 (the overflow
     guard, which measures against the card the engine does NOT derive from the text,
     went red first; traps.md #17).
   - The 9-chip Human bonus row, wider at the bigger font, blew the whole sheet past
     the viewport -> BonusRow HBoxContainer -> HFlowContainer so it wraps instead of
     forcing the sheet wide. Nothing depends on the row's type (tests check child
     count + visibility only).

319 client tests green (theme drift guard + overflow guard included); screenshot-
verified at 1280x720: granted chip owned, no clipping, bonus row wraps cleanly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Phillip Tarrant
2026-07-14 20:33:08 -05:00
parent 8f3aa75fa9
commit 1ae62fe0db
5 changed files with 101 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
client/scenes/creation/CharacterCreation.tscn
View File

@@ -145,7 +145,7 @@ layout_mode = 2
theme_override_constants/separation = 14
[node name="Race0" type="Button" parent="Split/Sheet/Body/RaceSection/Cards"]
custom_minimum_size = Vector2(0, 140)
custom_minimum_size = Vector2(0, 180)
layout_mode = 2
size_flags_horizontal = 3
toggle_mode = true
@@ -200,7 +200,7 @@ theme_type_variation = &"ChosenTag"
text = "CHOSEN"
[node name="Race1" type="Button" parent="Split/Sheet/Body/RaceSection/Cards"]
custom_minimum_size = Vector2(0, 140)
custom_minimum_size = Vector2(0, 180)
layout_mode = 2
size_flags_horizontal = 3
toggle_mode = true
@@ -255,7 +255,7 @@ theme_type_variation = &"ChosenTag"
text = "CHOSEN"
[node name="Race2" type="Button" parent="Split/Sheet/Body/RaceSection/Cards"]
custom_minimum_size = Vector2(0, 140)
custom_minimum_size = Vector2(0, 180)
layout_mode = 2
size_flags_horizontal = 3
toggle_mode = true
@@ -310,7 +310,7 @@ theme_type_variation = &"ChosenTag"
text = "CHOSEN"
[node name="Race3" type="Button" parent="Split/Sheet/Body/RaceSection/Cards"]
custom_minimum_size = Vector2(0, 140)
custom_minimum_size = Vector2(0, 180)
layout_mode = 2
size_flags_horizontal = 3
toggle_mode = true
@@ -774,9 +774,10 @@ toggle_mode = true
theme_type_variation = &"SkillChip"
text = "perception"
[node name="BonusRow" type="HBoxContainer" parent="Split/Sheet/Body/SkillSection"]
[node name="BonusRow" type="HFlowContainer" parent="Split/Sheet/Body/SkillSection"]
layout_mode = 2
theme_override_constants/separation = 10
theme_override_constants/h_separation = 10
theme_override_constants/v_separation = 8
[node name="Label" type="Label" parent="Split/Sheet/Body/SkillSection/BonusRow"]
layout_mode = 2