ptarrant/Code_of_Conquest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve NPC chat database persistence and modal targeting

Browse Source 
Fixed two critical bugs in NPC chat functionality:

  1. Database Persistence - Metadata serialization bug
     - Empty dict {} was falsy, preventing JSON conversion
     - Changed to unconditional serialization in ChatMessageService
     - Messages now successfully save to chat_messages collection

  2. Modal Targeting - HTMX targeting lost during polling
     - poll_job() wasn't preserving hx-target/hx-swap parameters
     - Pass targeting params through query string in polling cycle
     - Responses now correctly load in modal instead of main panel

  Files modified:
  - api/app/services/chat_message_service.py
  - public_web/templates/game/partials/job_polling.html
  - public_web/app/views/game_views.py
This commit is contained in:
Phillip Tarrant
2025-11-25 20:44:24 -06:00
parent 4353d112f4
commit 20cb279793
3 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
api/app/services/chat_message_service.py
View File

@@ -108,9 +108,9 @@ class ChatMessageService:
# Save to database
message_data = chat_message.to_dict()
# Convert metadata dict to JSON string for storage
if message_data.get('metadata'):
message_data['metadata'] = json.dumps(message_data['metadata'])
# Convert metadata dict to JSON string for storage (Appwrite requires string type)
# Always convert, even if empty dict (empty dict {} is falsy in Python!)
message_data['metadata'] = json.dumps(message_data.get('metadata') or {})
self.db.create_row(
table_id='chat_messages',